Fix incorrect display of trace IDs in the automatic_logging processor#4578
Merged
ptodev merged 3 commits intoJul 25, 2023
Merged
Conversation
Contributor
Author
|
I think it's better to use
For other use cases such as the one in the service graph processor, using |
tpaschalis
approved these changes
Jul 25, 2023
ptodev
added a commit
that referenced
this pull request
Jul 25, 2023
…#4578) * Fix incorrect spanId and traceId string conversion
ptodev
added a commit
that referenced
this pull request
Jul 25, 2023
dwalker-sabiogroup
pushed a commit
to dwalker-sabiogroup/agent
that referenced
this pull request
Jul 28, 2023
…grafana#4578) * Fix incorrect spanId and traceId string conversion
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…#4578) * Fix incorrect spanId and traceId string conversion
clayton-cornell
pushed a commit
that referenced
this pull request
Aug 14, 2023
…#4578) * Fix incorrect spanId and traceId string conversion
github-actions
Bot
added
the
frozen-due-to-age
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This is a bug which was introduced in the Otel upgrade in #3858. I must have gotten confused about the deprecation of the HexString function. Apologies for this - the bug could have been easily prevented if I'd taken more care reading the functions and the deprecation PR.
Which issue(s) this PR fixes
Fixes #4552
Notes to the Reviewer
There are two other places which use such code, but I think they are not impacted from an external user point of view:
SpanToKeyValfunction inpkg/integrations/v2/app_agent_receiver/payload.goappears to be unused.I will mention the service graph in the changelog anyway so that users are advised to upgrade.
I tested this locally for the automatic_logging processor only.
PR Checklist